don't move toolbar by block-hover on mobile

Resolves #1972
codex-team · Mar 25, 2022 · f9ae64c · f9ae64c
1 parent a9a06eb
commit f9ae64c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/components/modules/toolbar/index.ts b/src/components/modules/toolbar/index.ts
@@ -509,6 +509,14 @@ export default class Toolbar extends Module<ToolbarNodes> {
      * Subscribe to the 'block-hovered' event
      */
     this.eventsDispatcher.on(this.Editor.UI.events.blockHovered, (data: {block: Block}) => {
+      /**
+       * Do not move Toolbar by hover on mobile view
+       * @see https://github.com/codex-team/editor.js/issues/1972
+       */
+      if (_.isMobile()) {
+        return;
+      }
+
       /**
        * Do not move toolbar if Block Settings or Toolbox opened
        */

diff --git a/src/components/ui/toolbox.ts b/src/components/ui/toolbox.ts
@@ -155,7 +155,7 @@ export default class Toolbox extends EventsDispatcher<ToolboxEvent> {
       this.close();
     });
 
-    if (_.isMobile) {
+    if (_.isMobile()) {
       this.listeners.on(document, 'scroll', () => {
         this.close();
       });

diff --git a/src/components/utils.ts b/src/components/utils.ts
@@ -766,4 +766,6 @@ export function cacheable<Target, Value, Arguments extends unknown[] = unknown[]
 /**
  * True if screen has mobile size
  */
-export const isMobile = window.matchMedia('(max-width: 650px)').matches;
+export function isMobile(): boolean {
+  return window.matchMedia('(max-width: 650px)').matches;
+}