Throw error only if read-only is enabled from the start (#1337)

* Throw error only if read-only is enabled from the start * update modules
codex-team · Oct 2, 2020 · b836359 · b836359
1 parent 274cb76
commit b836359
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/dist/editor.js b/dist/editor.js
diff --git a/src/components/modules/readonly.ts b/src/components/modules/readonly.ts
@@ -13,6 +13,11 @@ import { CriticalError } from '../errors/critical';
  * @property {boolean} readOnlyEnabled - read-only state
  */
 export default class ReadOnly extends Module {
+  /**
+   * Array of tools name which don't support read-only mode
+   */
+  private toolsDontSupportReadOnly: string[] = [];
+
   /**
    * Value to track read-only state
    *
@@ -41,10 +46,10 @@ export default class ReadOnly extends Module {
       }
     });
 
-    if (toolsDontSupportReadOnly.length > 0) {
-      throw new CriticalError(
-        `To enable read-only mode all connected tools should support it. Tools ${toolsDontSupportReadOnly.join(', ')} don't support read-only mode.`
-      );
+    this.toolsDontSupportReadOnly = toolsDontSupportReadOnly;
+
+    if (this.config.readOnly && toolsDontSupportReadOnly.length > 0) {
+      this.throwCriticalError();
     }
 
     this.readOnlyEnabled = this.config.readOnly;
@@ -57,6 +62,10 @@ export default class ReadOnly extends Module {
    * @param {boolean} state - (optional) read-only state or toggle
    */
   public async toggle(state = !this.readOnlyEnabled): Promise<boolean> {
+    if (this.toolsDontSupportReadOnly.length > 0) {
+      this.throwCriticalError();
+    }
+
     this.readOnlyEnabled = state;
 
     for (const name in this.Editor) {
@@ -83,4 +92,13 @@ export default class ReadOnly extends Module {
 
     return this.readOnlyEnabled;
   }
+
+  /**
+   * Throws an error about tools which don't support read-only mode
+   */
+  private throwCriticalError(): never {
+    throw new CriticalError(
+      `To enable read-only mode all connected tools should support it. Tools ${this.toolsDontSupportReadOnly.join(', ')} don't support read-only mode.`
+    );
+  }
 }