Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started: finding kata #61

Merged
merged 10 commits into from
Jul 21, 2020
Merged

Getting started: finding kata #61

merged 10 commits into from
Jul 21, 2020

Conversation

hobovsky
Copy link
Contributor

@hobovsky hobovsky commented Jul 16, 2020

#40

Most of this page is reused content of original "getting started" pop-up presented currently to newbies. I reused it because I assumed that if it's still there, then it's good enough, but maybe you;d like to have it completely redone?

@hobovsky hobovsky requested a review from kazk July 16, 2020 23:32
@hobovsky hobovsky added the documentation Improvements or additions to documentation label Jul 16, 2020
@hobovsky hobovsky requested a review from kazk July 18, 2020 18:26
Copy link
Contributor

@Blind4Basics Blind4Basics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed. Some changes will depend on #74 last question

content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
@Blind4Basics
Copy link
Contributor

Blind4Basics commented Jul 20, 2020

'forgot about the picture:

in the first picture, I'd use "Training setup" rather than "Trainer setup" (it clashes with cw's "trainer". That's part of the reason I changed the title in one of the suggestions above)

hobovsky and others added 2 commits July 20, 2020 17:24
emphasize easy tasks and not difficult ones

Co-authored-by: Blind4Basics <[email protected]>
Co-authored-by: Blind4Basics <[email protected]>
content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
content/getting-started/finding-kata.md Outdated Show resolved Hide resolved
@kazk
Copy link
Member

kazk commented Jul 21, 2020

I think it's good enough as a first draft. We'll update as we add more linked docs. Also, we should open issues for improvements on existing pages.

By the way, when merging a pull request with many commits like this one, use "Squash and merge":

image

This will keep the commit history of the master branch clean, while keeping the incremental history here. I might make this the only option.

@kazk kazk merged commit a5dd707 into master Jul 21, 2020
@kazk kazk deleted the getting-started_finding-kata branch July 21, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants