Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sql-writting-tests.md #105

Merged
merged 15 commits into from
Aug 4, 2020
Merged

Create sql-writting-tests.md #105

merged 15 commits into from
Aug 4, 2020

Conversation

Blind4Basics
Copy link
Contributor

@Blind4Basics Blind4Basics commented Jul 29, 2020

  • Is the location of the file ok?
  • I completed the frontmatter, but without the sidebar and prev/next links => ok like that?
  • I let the extrenal links as they were in the original post (about that, I still wait some more feedback on Links general policy for the docs? #102 )

line 20: TODO

...Include examples, schema images, etc..._

@Blind4Basics Blind4Basics requested a review from kazk July 29, 2020 09:58
@Blind4Basics Blind4Basics linked an issue Jul 29, 2020 that may be closed by this pull request
@Blind4Basics Blind4Basics removed the request for review from kazk July 29, 2020 10:00
@Blind4Basics Blind4Basics marked this pull request as draft July 29, 2020 10:00
@Blind4Basics Blind4Basics marked this pull request as ready for review July 29, 2020 10:12
@Blind4Basics Blind4Basics requested a review from kazk July 29, 2020 10:12
@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented Jul 30, 2020

the review above being closed, I duplicate the message here:

Isn't there a way to get notifications for the reviews? (maybe it's sent by email? Then I'd have to change the one used for github... :/ )

Q: should we have a list of "topics" for the frontmatter, as we do for "kinds" or so? Because we might end up with test/tests/testing or so, at some point.

@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented Jul 30, 2020

btw, what about that:

line 20: TODO

...Include examples, schema images, etc..._

we let the page as it is for now? (this might belong to a tutorial rather than to the reference?)

@kazk
Copy link
Member

kazk commented Jul 30, 2020

Isn't there a way to get notifications for the reviews?

I only get notification on GitHub. We can add to Zulip if you want. (codewars/zulip-github-events#3)

Q: should we have a list of "topics" for the frontmatter, as we do for "kinds" or so?

We don't have Topic defined yet. Feel free to open an issue for collecting them.

we let the page as it is for now? (this might belong to a tutorial rather than to the reference?)

We can always improve the docs later so it's up to you.
This teaches someone how to write tests for SQL kata so it's a tutorial. Reference will be a list of available methods.


## Generalities

If you do use an existing SQL kata, be sure to avoid exposing the solution in the preloaded code file. It's easy for a code warrior to read the file in the sample tests and view the solution. Also, drop and recreate the database per `it` block so that there's no surprising state shared across cases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird as a first sentence on this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check that one tomorrow (too much tired for that now. It's actually the original text, I just updated the post of the issue to make it compatible with the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried something... Can you check again, plz?

content/languages/sql/sql-writting-tests.md Outdated Show resolved Hide resolved
content/languages/sql/sql-writting-tests.md Outdated Show resolved Hide resolved
content/languages/sql/sql-writting-tests.md Outdated Show resolved Hide resolved
content/languages/sql/sql-writting-tests.md Outdated Show resolved Hide resolved
content/languages/sql/sql-writting-tests.md Outdated Show resolved Hide resolved
@Blind4Basics
Copy link
Contributor Author

I only get notification on GitHub. We can add to Zulip if you want. (codewars/zulip-github-events#3)

Yup, would be cool, imo.

Q: should we have a list of "topics" for the frontmatter, as we do for "kinds" or so?

We don't have Topic defined yet. Feel free to open an issue for collecting them.

done (with a question already... XD )

@Blind4Basics Blind4Basics requested a review from kazk August 1, 2020 17:32
@Blind4Basics Blind4Basics merged commit 28b7167 into master Aug 4, 2020
@Blind4Basics Blind4Basics deleted the add-sql-tests-tutorial branch August 4, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

working example or tutorial about creating a sql kata
3 participants