-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn external links element into teasers element #2188
Draft
tf
wants to merge
19
commits into
codevise:master
Choose a base branch
from
tf:teasers-inline-editing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf
force-pushed
the
teasers-inline-editing
branch
3 times, most recently
from
January 16, 2025 14:11
b22741d
to
605c53e
Compare
Will be handled by EditableLink. REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
Remove workaround that broke inline rights copyright buttons. REDMINE-20852, REDMINE-20896
Generally, wrapping an element in an editable link should not change percentage sizes relative to its previous containing block. REDMINE-20852, REDMINE-20896
Prevent toolbar from being clipped by viewport or smaller containers like teaser cards. REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
Setting the element to inert for some reason causes `selectionchange` event not to be fired. REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
Align with hotspots behavior. Make it easier to create multiple items. REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
Keep supporting `title` value in CSS to stay compatible for the few users that already use the feature. We accept that the editor drop down will show "Below text". REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852
tf
force-pushed
the
teasers-inline-editing
branch
from
January 17, 2025 17:12
605c53e
to
7eab279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-20852, REDMINE-20896