Include chardet in dev dependencies

[Jackenmen]

Per README, you should run pip install -e ".[dev]" to install dependencies required for development but currently dev does not include chardet which is required for running one of the unit tests.

I also went ahead and removed the direct installation of the chardet dep since it's now installed by dev extra which both CI setups use.

[peternewman]

currently dev does not include chardet which is required for running one of the unit tests.

Which test is that? This one?

codespell/codespell_lib/tests/test_basic.py

Lines 261 to 284 in 3a17154

	def test_encoding(tmpdir, capsys):
	"""Test encoding handling."""
	# Some simple Unicode things
	with open(op.join(str(tmpdir), 'tmp'), 'w') as f:
	pass
	# with CaptureStdout() as sio:
	assert cs.main(f.name) == 0
	with open(f.name, 'wb') as f:
	f.write(u'naïve\n'.encode('utf-8'))
	assert cs.main(f.name) == 0
	assert cs.main('-e', f.name) == 0
	with open(f.name, 'ab') as f:
	f.write(u'naieve\n'.encode('utf-8'))
	assert cs.main(f.name) == 1
	# Binary file warning
	with open(f.name, 'wb') as f:
	f.write(b'\x00\x00naiive\x00\x00')
	code, stdout, stderr = cs.main(f.name, std=True, count=False)
	assert code == 0
	assert stdout == stderr == ''
	code, stdout, stderr = cs.main('-q', '0', f.name, std=True, count=False)
	assert code == 0
	assert stdout == ''
	assert 'WARNING: Binary file' in stderr

[Jackenmen]

Yep:

pytest codespell_lib
======================================= test session starts =======================================
platform linux -- Python 3.7.14, pytest-7.1.3, pluggy-1.0.0
rootdir: /home/ubuntu/work/codespell, configfile: setup.cfg
plugins: cov-3.0.0, dependency-0.5.1
collected 68 items                                                                                

codespell_lib/tests/test_basic.py .........F.............                                   [ 33%]
codespell_lib/tests/test_dictionary.py .....................ssssssssssssssss........        [100%]

============================================ FAILURES =============================================
__________________________________________ test_encoding __________________________________________

self = <codespell_lib._codespell.FileOpener object at 0x7f76669a2210>

    def init_chardet(self):
        try:
>           from chardet.universaldetector import UniversalDetector
E           ModuleNotFoundError: No module named 'chardet'

self       = <codespell_lib._codespell.FileOpener object at 0x7f76669a2210>

codespell_lib/_codespell.py:162: ModuleNotFoundError

During handling of the above exception, another exception occurred:

tmpdir = local('/tmp/pytest-of-ubuntu/pytest-2/test_encoding0')
capsys = <_pytest.capture.CaptureFixture object at 0x7f7666a1f810>

    def test_encoding(tmpdir, capsys):
        """Test encoding handling."""
        # Some simple Unicode things
        with open(op.join(str(tmpdir), 'tmp'), 'w') as f:
            pass
        # with CaptureStdout() as sio:
        assert cs.main(f.name) == 0
        with open(f.name, 'wb') as f:
            f.write(u'naïve\n'.encode('utf-8'))
        assert cs.main(f.name) == 0
>       assert cs.main('-e', f.name) == 0

capsys     = <_pytest.capture.CaptureFixture object at 0x7f7666a1f810>
f          = <_io.BufferedWriter name='/tmp/pytest-of-ubuntu/pytest-2/test_encoding0/tmp'>
tmpdir     = local('/tmp/pytest-of-ubuntu/pytest-2/test_encoding0')

codespell_lib/tests/test_basic.py:271: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
codespell_lib/tests/test_basic.py:31: in main
    code = cs_.main(*args, **kwargs)
        args       = ('--count', '-e', '/tmp/pytest-of-ubuntu/pytest-2/test_encoding0/tmp')
        count      = True
        kwargs     = {}
        self       = <codespell_lib.tests.test_basic.MainWrapper object at 0x7f766693b350>
        std        = False
codespell_lib/_codespell.py:865: in main
    options.quiet_level)
        args       = ('--count', '-e', '/tmp/pytest-of-ubuntu/pytest-2/test_encoding0/tmp')
        builtin    = ('rare', 'for rare (but valid) words that are likely to be errors', '_rare', None, None, None, ...)
        colors     = <codespell_lib._codespell.TermColors object at 0x7f76662ca910>
        context    = None
        dictionaries = ['-']
        dictionary = '/home/ubuntu/work/codespell/codespell_lib/data/dictionary_rare.txt'
        exclude_lines = set()
        ignore_word_regex = None
        ignore_words = set()
        ignore_words_files = []
        misspellings = {'1nd': <codespell_lib._codespell.Misspelling object at 0x7f76669a2ad0>, '2rd': <codespell_lib._codespell.Misspelling ...ell.Misspelling object at 0x7f76669a2290>, '3nd': <codespell_lib._codespell.Misspelling object at 0x7f76669a2b50>, ...}
        options    = Namespace(after_context=None, before_context=None, builtin='clear,rare', check_filenames=False, check_hidden=False, co..., quiet_level=2, regex=None, skip=None, summary=False, uri_ignore_words_list=None, uri_regex=None, write_changes=False)
        parser     = ArgumentParser(prog='pytest', usage=None, description=None, formatter_class=<class 'codespell_lib._codespell.NewlineHelpFormatter'>, conflict_handler='error', add_help=True)
        summary    = None
        u          = 'rare'
        uri_ignore_words = set()
        uri_regex  = re.compile('(\\b(?:https?|[ts]?ftp|file|git|smb)://[^\\s]+(?=$|\\s)|\\b[\\w.%+-]+@[\\w.-]+\\b)')
        use        = ['clear', 'rare']
        use_dictionaries = ['/home/ubuntu/work/codespell/codespell_lib/data/dictionary.txt', '/home/ubuntu/work/codespell/codespell_lib/data/dictionary_rare.txt']
        word_regex = re.compile("[\\w\\-'’`]+")
codespell_lib/_codespell.py:157: in __init__
    self.init_chardet()
        quiet_level = 2
        self       = <codespell_lib._codespell.FileOpener object at 0x7f76669a2210>
        use_chardet = True
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <codespell_lib._codespell.FileOpener object at 0x7f76669a2210>

    def init_chardet(self):
        try:
            from chardet.universaldetector import UniversalDetector
        except ImportError:
>           raise ImportError("There's no chardet installed to import from. "
                              "Please, install it and check your PYTHONPATH "
                              "environment variable")
E           ImportError: There's no chardet installed to import from. Please, install it and check your PYTHONPATH environment variable

self       = <codespell_lib._codespell.FileOpener object at 0x7f76669a2210>

codespell_lib/_codespell.py:164: ImportError
======================================== warnings summary =========================================
codespell_lib/tests/test_dictionary.py:29
  /home/ubuntu/work/codespell/codespell_lib/tests/test_dictionary.py:29: UserWarning: aspell not found, but not required, skipping aspell tests. Got error during import:
  No module named 'aspell'
    'error during import:\n%s' % (exp,))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html


===================================== short test summary info =====================================
SKIPPED [16] codespell_lib/tests/test_dictionary.py:163: requires aspell-en
====================== 1 failed, 51 passed, 16 skipped, 1 warning in 37.96s =======================

[Jackenmen]

I resolved conflicts in case anyone wants to look at this again.

[DimitriPapadopoulos]

@Jackenmen Could you (i) fix the black issue, and (ii) rebase to fix the unrelated CI error?

[Jackenmen]

@DimitriPapadopoulos did just a rebase which should fix both problems since the black issue is unrelated to my changes as well.