Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"--interactive" useless without "-w" #3220

Closed
buhtz opened this issue Nov 15, 2023 · 4 comments
Closed

"--interactive" useless without "-w" #3220

buhtz opened this issue Nov 15, 2023 · 4 comments
Assignees
Labels

Comments

@buhtz
Copy link

buhtz commented Nov 15, 2023

I tried codespell -i 3 to check errors and select modifications offered by codespell.
But the files are not modified even if I have chosen Y.

It only works when I add -w.

From a users perspective I would expect that -i implicates -w.

@MercuryDemo
Copy link
Contributor

hi, can i work on this issue?I'm looking for my first issue on github.

MercuryDemo pushed a commit to MercuryDemo/codespell that referenced this issue Jan 30, 2024
By modifying the initial value of interactive and directly modifying the value of write_changes when the user selects the interactive model
But I don't think this is the best solution, because codespell doesn't make any limitations on the value of interactive entered by the user, while the execution only supports 0, 1, 2, 3
@buhtz
Copy link
Author

buhtz commented Mar 10, 2024

Damn. Run again into this bug and wasted half hour of my lifetime.

Suggestion: If you disagree that "-i" should implicate "-w" then minimally there should be warning when using "-i" without "-w". Related to #2190

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Mar 10, 2024

I'd be happy to merge #3340 once the issues have been fixed.

@DimitriPapadopoulos
Copy link
Collaborator

Closed by #3340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants