Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-adding "shouldnot" to allow dictionary #2528

Closed
jackfrancis opened this issue Oct 14, 2022 · 3 comments · Fixed by #2747
Closed

Consider re-adding "shouldnot" to allow dictionary #2528

jackfrancis opened this issue Oct 14, 2022 · 3 comments · Fixed by #2747
Labels
dictionary Changes to the dictionary

Comments

@jackfrancis
Copy link

Hi folks,

It seems that w/ today's v2.2.2 release the word "shouldnot" has been demoted to "not allowed by default". Because terms like Should and ShouldNot are rather common in test assertion libraries across the developer ecosystem, I wonder if other folks had to quickly update their ignore files today to unblock CI.

Here's one example of some usages in the golang ginkgo test framework:

Thanks for consideration!

@peternewman peternewman added the dictionary Changes to the dictionary label Oct 17, 2022
@peternewman
Copy link
Collaborator

Hi @jackfrancis ,

While it's clearly not a valid word, please feel free to open a PR to move it into the code dictionary, then it won't be enabled by default only if people request to scan with that dictionary (hopefully not on code).

@jackfrancis
Copy link
Author

Thank you @DimitriPapadopoulos !

@DimitriPapadopoulos
Copy link
Collaborator

You're welcome and thank you for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants