Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to make "uri_ignore_words_list" work ? #55

Open
chipitsine opened this issue Dec 11, 2022 · 3 comments
Open

how to make "uri_ignore_words_list" work ? #55

chipitsine opened this issue Dec 11, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@chipitsine
Copy link

we use codespell in haproxy, I tried to ignore uri:

chipitsine/haproxy@5e2fd69

uri are still detected:

https://github.com/chipitsine/haproxy/actions/runs/3670466510/jobs/6205020701

particularly

image

text is

    >>> Aug  9 20:30:46 localhost \
          haproxy[2022]: 127.0.0.1:34020 [09/Aug/2004:20:30:46] proxy-out \
          proxy-out/cache1 0/0/0/182/+182 200 +279 - - ---- 0/0/0/0/0 0/0 \
          {w.ods.org||} {Formilux/0.1.8|3495|||} \
          "GET http://trafic.1wt.eu/ HTTP/1.1"
@peternewman peternewman added the bug Something isn't working label Dec 11, 2022
@peternewman
Copy link
Collaborator

Agreed this seems to be a bug as the wildcard isn't working as expected. Specifying it manually works as you'll see here:
https://github.com/peternewman/haproxy/actions/runs/3671097944/jobs/6206070167

But you'll need to ignore the word in the GitHub workflow file then.

I believe the underlying codespell wildcard works, so this is probably something to do with how we're handling it in the Action. If you want to switch to using a config file, I suspect that will fix it too:
https://github.com/codespell-project/codespell#using-a-config-file

@shipitsin-ilia
Copy link

it is not documented how to use config with actions, is that possible?

@chipitsine
Copy link
Author

any update on this ?

haproxy-mirror pushed a commit to haproxy/haproxy that referenced this issue Jan 12, 2024
"trafic,ressources" are found in URIs, due to
codespell-project/actions-codespell#55 we cannot use
wildcard for exclusion, let start with fixed list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants