fix(sw): support fixed id value #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
CompuIves
reviewed
Sep 10, 2024
| @@ -7,13 +7,17 @@ export default { | |||
| title: "Intro/Playground", | |||
| }; | |||
|
|
|||
| localStorage.setItem("SANDPACK_INTERNAL:URL-CONSISTENT-ID", "123123123"); | |||
There was a problem hiding this comment.
Is this needed? Should the user do this too?
CompuIves
reviewed
Sep 10, 2024
| const getStableServiceWorkerId = async () => { | ||
| const key = `SANDPACK_INTERNAL:URL-CONSISTENT-ID`; | ||
| const fixedId = localStorage.getItem(key); | ||
| if (fixedId) { |
There was a problem hiding this comment.
Maybe we should do localStorage.setItem for the id if it turns out it's not set (with a random id). Then we don't have to ask the user to set it.
…m/codesandbox/sandpack into fix/sw-consistent-id
CompuIves
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.