Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged qos features. #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Merged qos features. #210

wants to merge 1 commit into from

Conversation

kaneko60
Copy link

@kaneko60 kaneko60 commented Nov 6, 2020

The qos features developed by Lee Savoie are merged.

The qos features developed by Lee Savoie are merged.
@nmcglo
Copy link
Member

nmcglo commented Nov 6, 2020

Looks like some good work here! We currently have some QoS implementation embedded into a couple of our Dragonfly models. Utilizing a model net scheduler is an interesting idea.

I will say, merging this into mainline will be a process. We'll want to make sure that if there was simulation determinism prior to these changes that it is maintained. Same thing for parallelism/reverse computation.

Another is we'll want to find a way to distinguish between various QoS implementations in the code base so as not to confuse anyone if they, for instance, tried to configure a dragonfly QoS and accidentally utilize the new QoS model-net-scheduler.

And prior to merging, we'd like some sort of validation to show that this does what it's supposed to and documentation for how to use it. CODES hasn't always been great about documentation but I'm working to try and fix that going forward.

We've got a few other things in the pipeline that we're working on merging as well - including QoS related stuff so this will be an interesting merge process 😅

Thanks again, it's interesting work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants