Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rehost test dumpi file #186

Closed
nmcglo opened this issue Oct 11, 2019 · 2 comments
Closed

Rehost test dumpi file #186

nmcglo opened this issue Oct 11, 2019 · 2 comments
Assignees
@nmcglo
Labels
low priority This issue is not actively worked on but isn't a wontfix

Comments

@nmcglo
Copy link
Member

nmcglo commented Oct 11, 2019

The NERSC website that hosts the DoE miniapp trace files we use appears to go down any time LBNL loses power which is happening with greater frequency. When make check is run while the website is down, the download-traces.sh script in tests/ will hang until wget times out (I haven't had the patience to find out when that is). download-traces.sh is run when make check is called when dumpi is installed with CODES.

The AMGn27 trace file that we use for make check should be rehosted or bundled so that a power outage due to strong winds in California doesn't break our test suite.
@nmcglo nmcglo self-assigned this Oct 11, 2019
@nmcglo nmcglo added the low priority This issue is not actively worked on but isn't a wontfix label Oct 21, 2019
nmcglo added a commit that referenced this issue Oct 23, 2019
@nmcglo
Rehost make check test dumpi trace file
aebf8d0 
Addressing issue #186.
@nmcglo
Copy link
Member Author

nmcglo commented Oct 23, 2019

For now I've hosted it on my own website. This isn't a long term solution - we could put it in its own codes-org repository. Like codes-files or something that we could wget from the URL from there but it doesn't make a ton of sense to do that just for one file; maybe once we have a lot more files to host then we could consider that.

Maybe that's just the avenue that should be taken anyway. In the mean time, closing.

@nmcglo nmcglo closed this as completed Oct 23, 2019
nmcglo added a commit that referenced this issue Nov 8, 2019
@nmcglo
Rehost dumpi trace file for make check again
5138b61 
Re-address #186. Now directs to a file hosted by codes-org on github
instead of a personal webpage. It's just cleaner that way.
@nmcglo
Copy link
Member Author

nmcglo commented Nov 8, 2019

Now it points to the previously mentioned codes-files repo within codes-org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmcglo nmcglo

Labels
low priority This issue is not actively worked on but isn't a wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmcglo