Fixes #547: jQuery selector expected #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django jQuery tabularFormset function exptects first parameter to be a selector and second parameter to be options. Seems it used to be different once upon a time and selector was not required, because function is called on already selected object. But ... an empty selector is good enough, so we make jQuery happy, for jQuery being able to make us happy. Now there's an "Add" link again show in inline tabular form. :)
pitpalme
force-pushed
the
fix/547-javascript-error-in-admin
branch
from
1cb1b1d
to
93ab6b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django jQuery tabularFormset function exptects first parameter to be a
selector and second parameter to be options.
Seems it used to be different once upon a time and selector was not
required, because function is called on already selected object.
But ... an empty selector is good enough, so we make jQuery happy, for
jQuery being able to make us happy.
Now there's an "Add" link again show in inline tabular form. :)