Restrict new usernames #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophmeissner
force-pushed
the
feature/494-restrict-usernames
branch
from
6d6aa11
to
dbc4919
Compare
pitpalme
reviewed
Mar 28, 2022
christophmeissner
force-pushed
the
feature/494-restrict-usernames
branch
from
7a21908
to
95bec05
Compare
pitpalme
previously approved these changes
Mar 29, 2022
New users may only select usernames following this rules: * min 3, max 16 characters * starts with an letter and ends with an letter or number * may only contain [a-zA-Z0-9_.] fixes coders4help#494
* allow umlauts * allow _ at end * simplify regex * add positive tests for allowed usernames
Error message was changed but the expected error text in the test was not changed
christophmeissner
force-pushed
the
feature/494-restrict-usernames
branch
from
e416982
to
cd793ee
Compare
pitpalme
previously approved these changes
Mar 29, 2022
Co-authored-by: pitpalme <[email protected]>
christophmeissner
force-pushed
the
feature/494-restrict-usernames
branch
from
9fddc52
to
6534257
Compare
pitpalme
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New users may only select usernames following these rules:
_.,_.or_or any combination of those two, (ie. no..,__,._or_.)fixes #494