Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce flake8 checks in PR workflow #519

Merged
merged 10 commits into from
Mar 25, 2022
Merged

Enforce flake8 checks in PR workflow #519

merged 10 commits into from
Mar 25, 2022

Conversation

christophmeissner
Copy link
Contributor

  • Enforces flake8 checks in PR workflow
  • Fixes flake8 linter problems:
    • E501 line too long
    • E722 do not use bare 'except'
    • F401 unused import
    • F811 redefinition of unused
    • F841 unused local variable
    • W605 invalid escape sequence

@christophmeissner christophmeissner changed the title Chore/fix flake8 linter problems Enforce flake8 checks in PR workflow Mar 25, 2022
@christophmeissner
Update flake8 config
b71b77c 
add rule F401 (unused imports) to ignored rules for config modules
pitpalme
pitpalme previously approved these changes Mar 25, 2022
View reviewed changes
scheduler/management/commands/create_dummy_data.py Outdated Show resolved Hide resolved
@christophmeissner christophmeissner merged commit ee62512 into coders4help:develop Mar 25, 2022
@christophmeissner christophmeissner deleted the chore/fix-flake8-linter-problems branch March 25, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitpalme pitpalme pitpalme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophmeissner @pitpalme