-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Command Name and fix Typo #6
Conversation
Changed the Name for the Command to ``make:presenter`` to follow the usual Laravel make commands.
Hey, @syntafin Sorry for the late response. It seems a bit of time since this Changing the command Name could be a breaking changes, and I don't think we could afford that. What to do instead is, make a new command as an alias, and let the users knows (on the README.md) that there's a main command and an alias. Looking for your collaborations. Thanks for your time/PR. |
I can take a look into this tomorrow, and commit a alias command. |
Sounds Great! Thanks, @syntafin |
There is now the alias command for it. |
I don't think adding a new alias for a command, needs to deprecate the other one, for example look at livewire commands
And so on... Also, I have updated the service provide, and I added an extra test for the new command |
It looks all the tests passed, thank you, @syntafin, for your PR and your time. |
Changed the Command from
presenter:make
tomake:presenter
to follow the other commands in Laravel to create new classes.Fixed small typo in description.