Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Command Name and fix Typo #6

Merged
merged 9 commits into from
Aug 14, 2022
Merged

Change Command Name and fix Typo #6

merged 9 commits into from
Aug 14, 2022

Conversation

syntafin
Copy link
Contributor

@syntafin syntafin commented Jun 6, 2022

Changed the Command from presenter:make to make:presenter to follow the other commands in Laravel to create new classes.
Fixed small typo in description.

Changed the Name for the Command to ``make:presenter`` to follow the usual Laravel make commands.
@ousid
Copy link
Member

ousid commented Aug 12, 2022

Hey, @syntafin

Sorry for the late response.

It seems a bit of time since this PR.

Changing the command Name could be a breaking changes, and I don't think we could afford that.

What to do instead is, make a new command as an alias, and let the users knows (on the README.md) that there's a main command and an alias.

Looking for your collaborations.

Thanks for your time/PR.

@ousid ousid assigned ousid and syntafin and unassigned ousid Aug 12, 2022
@ousid ousid added the enhancement New feature or request label Aug 12, 2022
@syntafin
Copy link
Contributor Author

I can take a look into this tomorrow, and commit a alias command.

@ousid
Copy link
Member

ousid commented Aug 12, 2022

Sounds Great! Thanks, @syntafin

@syntafin
Copy link
Contributor Author

There is now the alias command for it.
I marked presenter:make as deprecated, so it can be dropped in a future major release.

@ousid
Copy link
Member

ousid commented Aug 14, 2022

I don't think adding a new alias for a command, needs to deprecate the other one, for example look at livewire commands

php artisan livewire:mv ... is an alias for php artisan livewire:move

php artisan make:livewire ... is an alias for php artisan livewire:make

And so on...

Also, I have updated the service provide, and I added an extra test for the new command

@ousid ousid merged commit 147bebd into coderflexx:main Aug 14, 2022
@ousid
Copy link
Member

ousid commented Aug 14, 2022

It looks all the tests passed, thank you, @syntafin, for your PR and your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants