Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go module version to 1.18 #381

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Update Go module version to 1.18 #381

merged 1 commit into from
Oct 10, 2023

Conversation

Jacalz
Copy link
Contributor

@Jacalz Jacalz commented Mar 12, 2023

Fixes #359

@Jacalz Jacalz requested a review from nhooyr as a code owner March 12, 2023 14:44
@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 12, 2023

With this landed, it should be possible to fix #370 and then move test dependencies out into a separate package before a new release.

@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 26, 2023

@nhooyr Any chance to get this merged? It would be good if you could get this project rolling again.

nhooyr
nhooyr approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay thanks @Jacalz

@nhooyr nhooyr merged commit 315dcd9 into coder:dev Oct 10, 2023
@Jacalz Jacalz deleted the go118 branch October 10, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jacalz @nhooyr