Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use net.ErrClosed #286

Closed
emersion opened this issue Mar 10, 2021 · 2 comments · Fixed by #303
Closed

Use net.ErrClosed #286

emersion opened this issue Mar 10, 2021 · 2 comments · Fixed by #303
Milestone

Comments

@emersion
Copy link
Contributor

Go 1.16 has introduced net.ErrClosed, which should be returned/wrapped when an I/O call is performed on a network connection which has already been closed. This is useful to avoid cluttering logs with messages like failed to close WebSocket: already wrote close.

@nhooyr nhooyr added this to the v1.9.0 milestone Apr 7, 2021
@nhooyr
Copy link
Contributor

nhooyr commented Apr 7, 2021

Will do, thanks for reporting!

emersion added a commit to emersion/websocket that referenced this issue May 19, 2021
Go 1.16 has introduced net.ErrClosed, which should be returned/wrapped when an
I/O call is performed on a network connection which has already been closed.
This is useful to avoid cluttering logs with messages like "failed to close
WebSocket: already wrote close".

Closes: coder#286
emersion added a commit to emersion/websocket that referenced this issue May 19, 2021
Go 1.16 has introduced net.ErrClosed, which should be returned/wrapped when an
I/O call is performed on a network connection which has already been closed.
This is useful to avoid cluttering logs with messages like "failed to close
WebSocket: already wrote close".

Closes: coder#286
emersion added a commit to emersion/websocket that referenced this issue May 19, 2021
Go 1.16 has introduced net.ErrClosed, which should be returned/wrapped when an
I/O call is performed on a network connection which has already been closed.
This is useful to avoid cluttering logs with messages like "failed to close
WebSocket: already wrote close".

Closes: coder#286
emersion added a commit to emersion/websocket that referenced this issue Mar 7, 2023
Go 1.16 has introduced net.ErrClosed, which should be returned/wrapped when an
I/O call is performed on a network connection which has already been closed.
This is useful to avoid cluttering logs with messages like "failed to close
WebSocket: already wrote close".

Closes: coder#286
nhooyr pushed a commit to emersion/websocket that referenced this issue Oct 13, 2023
Go 1.16 has introduced net.ErrClosed, which should be returned/wrapped when an
I/O call is performed on a network connection which has already been closed.
This is useful to avoid cluttering logs with messages like "failed to close
WebSocket: already wrote close".

Closes: coder#286
@nhooyr
Copy link
Contributor

nhooyr commented Oct 13, 2023

Done in #303

@nhooyr nhooyr closed this as completed Oct 13, 2023
@nhooyr nhooyr modified the milestones: v1.9.0, v1.8.8 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants