chore(integration): update TestLogs to validate that CODER_ASGENT_SUBSYSTEM is set correctly #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YSTEM is set correctly
mafredri
approved these changes
Oct 28, 2024
| logBytes, err := io.ReadAll(logReader) | ||
| require.NoError(t, err) | ||
| logs := string(logBytes) | ||
| require.Contains(t, logs, "CODER_AGENT_SUBSYSTEM=envbuilder") |
There was a problem hiding this comment.
Is this relevant for the logs test, or just something we want to verify in general? Would it make more sense in a more env-targeted test or some other behavior?
There was a problem hiding this comment.
It only gets set if CODER_AGENT_URL and CODER_AGENT_TOKEN are set. It's not set otherwise. This is more of a convenient place to co-locate it.
| return false | ||
| } | ||
| return !status.State.Running | ||
| }, 10*time.Second, time.Second, "container never exited") |
There was a problem hiding this comment.
Could 10 seconds be potentially flaky?
There was a problem hiding this comment.
Potentially, but I think it's relatively unlikely that it will take that long to execute env and for the container to exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had no test coverage that
CODER_AGENT_SUBSYSTEMwas actually being set. This adds a check to ensure that it is.