Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update coverage thresholds #3832

Merged
merged 3 commits into from
Jul 21, 2021
Merged

chore: update coverage thresholds #3832

merged 3 commits into from
Jul 21, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 21, 2021

This PR updates the coverage threshold for codecov and Jest.

It changes the threshold to 60 for Jest meaning the unit tests must hit at least 60% coverage or it will fail.

It also turns off the patch requirement for codecov. We do this because sometimes PRs touch files in minor areas that have yet to be tested resulting in the patch requirement failing even if the author increased coverage in other areas. In the future, we can turn this back on.

It also changes the range to 40-70 meaning above 70% codecov will be green, less than 40 will be red and anything in between will approach green. We do this so the badge isn't read in the README and it's a reminder that we are indeed making progress on the code coverage increase.

Read more in the codecov docs.

@jsjoeio jsjoeio requested a review from a team as a code owner July 21, 2021 18:18
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks for the comprehensive PR description!

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #3832 (3b78bb2) into main (0f45152) will not change coverage.
The diff coverage is n/a.

❗ Current head 3b78bb2 differs from pull request most recent head 7ac015e. Consider uploading reports for the commit 7ac015e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3832   +/-   ##
=======================================
  Coverage   62.05%   62.05%           
=======================================
  Files          36       36           
  Lines        1863     1863           
  Branches      378      378           
=======================================
  Hits         1156     1156           
  Misses        601      601           
  Partials      106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f45152...7ac015e. Read the comment docs.

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Jul 21, 2021
@jsjoeio jsjoeio added this to the 3.12.0 milestone Jul 21, 2021
@jsjoeio jsjoeio enabled auto-merge July 21, 2021 18:23
@jsjoeio jsjoeio merged commit d0d739b into main Jul 21, 2021
@jsjoeio jsjoeio deleted the jsjoeio-codecov branch July 21, 2021 18:34
@jsjoeio jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
@ahmadyahya11 ahmadyahya11 mentioned this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants