-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dev): migrate away from parcel and replace with browserify #3658
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3658 +/- ##
==========================================
- Coverage 61.28% 59.87% -1.41%
==========================================
Files 35 35
Lines 1803 1797 -6
Branches 409 364 -45
==========================================
- Hits 1105 1076 -29
- Misses 556 605 +49
+ Partials 142 116 -26
Continue to review full report at Codecov.
|
Note, I'm not sure if this is 100% accurate. I did indeed add tests. However, half of the files under "Impacted Files" I didn't actually touch. I tried to investigate further the codecov docs and tried a couple things to fix this but didn't have any luck. |
526e69a
to
4383911
Compare
This also refactors a couple CSS stylesheets to be referenced directly in the HTML files. And it removes any CSS imports from src/browser files.
4383911
to
6e1455d
Compare
This PR migrates us away from Parcel by using
tsc
andbrowserify
to accomplish the same thing.Originally, we needed to upgrade Parcel from v1 to v2 due to maintainers deprecating v1 and a bunch of security vulnerabilities that we couldn't patch in v1. We were going to use v2 but it has breaking changes. So we decided to replace it with
browserify
which is a bit more lightweight and does the same thing.Changes
parcel
tsc
to compile.ts
files andbrowserify
to bundle a few files used in the browsercss
files directly in HTML instead of including withjs
bundlesbrowserify
plugintinyify
)Screenshot
Screenshot after building and running locally
Checklist
CHANGELOG.md
Related