Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace actions #196

Closed
2 tasks
avelino opened this issue Mar 11, 2019 · 12 comments
Closed
2 tasks

workspace actions #196

avelino opened this issue Mar 11, 2019 · 12 comments
Labels
waiting-for-info Waiting for more information from submitter

Comments

@avelino
Copy link
Contributor

avelino commented Mar 11, 2019

  • code-server version: master branch
  • OS Version: Ubuntu 18.04

Description

https://code.visualstudio.com/docs/editor/multi-root-workspaces#_workspace-file-schema

VSCode is supported in Create Workspace, when opening the workspace configuration file automatically pops up a button to load the workspace, this button is not working

Screen Shot 2019-03-11 at 8 49 53 AM

  • close workspace not working
  • load workspace not working

Steps to Reproduce

https://code.visualstudio.com/docs/editor/multi-root-workspaces#_opening-workspace-files

@avelino avelino added the bug Something isn't working label Mar 11, 2019
@avelino avelino changed the title open workspace button workspace actions Mar 11, 2019
@jwulf
Copy link

jwulf commented Mar 13, 2019

If I try opening the workspace file directly from the File > Open dialog, then a key is written to local storage for the workspace with a file path. On refreshing the page, the bundle does not load as the file path fails URI schema validation.

To recover, I have to delete the workspace key from local storage.

@geoah
Copy link

geoah commented Mar 16, 2019

Having the same issue that @jwulf mentioned. "File > Open Workspace" results in a blank (grey) page with no options. On my local installation I was able to recover by wiping .local, but on ide.coder.com there is nothing I can do and the editor is unusable. (Console says Failed "Start workbench")

@krazyito65
Copy link

Having the same issue that @jwulf mentioned. "File > Open Workspace" results in a blank (grey) page with no options. On my local installation I was able to recover by wiping .local, but on ide.coder.com there is nothing I can do and the editor is unusable. (Console says Failed "Start workbench")

I couldn't recover by wiping ~/.local/ is that the correct location? I've only been able to get it to work after using a workspace action with incognito mode.

@jwulf
Copy link

jwulf commented Mar 18, 2019

Open developer tools in your browser. In Chrome you are looking for the Application > Local Storage tab. Something like that. It is HTML Local Storage in the browser client, which is why Incognito mode works.

@vnijs
Copy link

vnijs commented May 4, 2019

FYI Saving a workspace file doesn't seem to work from the command palette (i.e., nothing happens after providing a name). So I created one in vscode and tried to open it using code-server. It shows the content of the file and a button to open the workspace (see screenshot). Clicking the button shows the the following error in developer tools.

image

image

@ghost
Copy link

ghost commented Jun 9, 2019

im wondering if #490 is related to this and if #755 fixes this

@melroy89
Copy link

I though it was me.. but apparently its not implemented..

@sr229
Copy link
Contributor

sr229 commented Sep 12, 2019

Hey OP, can you try out v2? I think we have workspaces implemented

@code-asher code-asher added waiting-for-info Waiting for more information from submitter and removed bug Something isn't working labels Oct 23, 2019
@melroy89
Copy link

melroy89 commented Nov 1, 2019

@sr229 I think V2 gives me only more problems now.

Issue nr. 1:

Clicking on the folder won't change the path (which either stays /home or /), see video:

Watch the video

Issue nr. 2:
Moreover, I pressed 'OK', redirected me to a blank page. Which was rather confusing..

Issue nr. 3:
Eventually the folder was added to the explorer, but I can't remove it from the explorer without removing the content. Now /home/coder folder was added accidentally, which is not ideal.

@code-asher
Copy link
Member

If you're using Firefox you might be running into this issue: #1063

@melroy89
Copy link

melroy89 commented Nov 1, 2019

Yep firefox.

@sr229
Copy link
Contributor

sr229 commented Nov 4, 2019

We've opened this in Microsoft/vscode so it will be the web team that'll be in charge of this from now on.

@sr229 sr229 closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-info Waiting for more information from submitter
Projects
None yet
Development

No branches or pull requests

8 participants