[v2] Folder selector not working as intended (Firefox)

[EnKrypt]

• code-server version: 2.1485-vsc1.38.1
• OS Version: Arch Linux (rolling release)

Description

The folder selector seems to be very glitched, making it near impossible to open the folder I want.

Specifically, one of the main bugs seems to be that selecting a folder by left clicking or hitting return on a dropdown entry, does not reflect on the path in the bar.

As such, the "OK" button does not work as intended either.

This bug is consistently reproducible.

[sr229]

Confirming bug existing on latest v2 and master branch.

[EnKrypt]

Any ideas where I can start looking if I wanted to find a fix myself?

Could this be coming from upstream, or is there any specific part of our codebase that I could probe?

[sr229]

From what can I see this is more than likely a upstream bug as well since we're not doing particularly anything on the "open folder" feature.

[code-asher]

Wow, there's some really weird behavior with the open dialog on Firefox. When I stepped through it the difference seemed to be that Firefox maintains the input as the active element while Chrome doesn't and VS Code runs different code based on whether the input is active or not which results in this discrepancy.

[code-asher]

And I'll also note that this affects the initial text in the input as describe in #1051.

[code-asher]

The code in question:

https://github.com/microsoft/vscode/blob/6ab598523be7a800d7f3eb4d92d7ab9a66069390/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts#L641

Essentially Firefox ends up running execCommand while Chromium ends up setting the text directly. I haven't looked deeper though to see whether this is a browser bug or a bug in the VS Code codebase.

[Developer626]

I've been having the same issue, and can confirm that this happens on Firefox and not Chrome (mobile and desktop).

[sr229]

Hey OP, I'll be closing this since Microsoft has stated they would want this be seen on the main vscode project. Make sure to prefix [web] and use the same exact details here (with the exception of code-server version). Thanks for helping us out spot bugs!

[EnKrypt]

Sounds good. No problem and thank you.