🔌 Use the model connection for the Schema checks #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain setups, models have a different connection set directly on the model by overloading the
getConnectionName(). Examples of this would be spatie/laravel-multitenancy.When this is the case, the tests will fail as the connection is not the "default".
This PR determines makes use of the model's
getConnection()method and sets this on theSchemadirectly. Then the correct connection is used.There is a check in the
getModelConnection()method to ensure that a model is present and that it is a suitable model class.I don't think that this is a breaking change as the tests all pass. However, as this uses the model connection now, it could be worth a second set of eyes looking over it to make sure that there aren't any fringe cases that aren't obvious.