fix(cli): when error opening a link - show it in console #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
commit: |
|
I tried the 
|
mohebifar
reviewed
Nov 13, 2024
apps/cli/src/utils/open.ts
Outdated
Comment on lines
6
to
9
| // Show url inside coder | ||
| if (process.env.CODER_WORKSPACE_AGENT_NAME) { | ||
| throw new Error("Cannot open browser in a headless environment"); | ||
| } |
There was a problem hiding this comment.
Hmm, our problem is not with coder only. Any environment without an x-11 system will fail (e.g. most CI/CD agents). We need to just detect if x11 is missing, and skip opening altogether instead of inferring it based on a specific type of agent (coder).
There was a problem hiding this comment.
I rechecked everything - open does work in coder env, but this should be installed sudo apt install xdg-utils.
The problem was with keytar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
When there is an error opening a link - show in CLI output
🔗 Linked Issue
🧪 Test Plan
📄 Documentation to Update