Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial and complete translation to Lithuanian #68

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

dgvirtual
Copy link
Contributor

Please include translation of CI4 to Lithuanian into the general translations repository. I did translate the whole set of files, despite my initial hesitation. I did not do unit checks – this is still beyond my knowledge of PHP programming.

@dgvirtual
Copy link
Contributor Author

Sorry, but what do I do now? I did commit those files without signing, only learned about the signing requirement after. What do I do now?

@jim-parry
Copy link
Contributor

There are a couple of tricks that would get you through signing these, but I am ok letting this one through if you can figure out signing for updates. Deal?

@jim-parry jim-parry merged commit 168c74c into codeigniter4:develop Oct 31, 2019
@dgvirtual
Copy link
Contributor Author

dgvirtual commented Oct 31, 2019

OK, thank you, I do use GPG and I did configure my github profile and git for use with GPG after learning about the requirement. I will sign my commits in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants