Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fa] Add missing translations Security #463

Merged
merged 3 commits into from
Jun 19, 2024
Merged

[fa] Add missing translations Security #463

merged 3 commits into from
Jun 19, 2024

Conversation

Nightprince
Copy link
Contributor

@Nightprince Nightprince commented Jun 17, 2024 •
edited by kenjis
Loading

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

datamweb
datamweb reviewed Jun 17, 2024
View reviewed changes
Language/fa/Security.php Outdated Show resolved Hide resolved
@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Jun 17, 2024
@kenjis kenjis removed the GPG-Signing needed Pull requests that need GPG-Signing label Jun 19, 2024
datamweb
datamweb approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@paulbalandan paulbalandan merged commit ceff88a into codeigniter4:develop Jun 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nightprince @kenjis @datamweb @paulbalandan