Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove strong_password from shield:user validation rules #853

Merged
merged 1 commit into from
Sep 24, 2023
Merged

fix: remove strong_password from shield:user validation rules #853

merged 1 commit into from
Sep 24, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 24, 2023 •
edited
Loading

Description
Follow-up #833

In previous versions, we used strong_password not strong_password[].

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
fix: remove strong_password
ac302be 
In previous versions, we used `strong_password` not `strong_password[]`.
@kenjis kenjis changed the title fix: remove strong_password fix: remove strong_password from shield:user validation rules Sep 24, 2023
@kenjis kenjis merged commit cbaa02f into codeigniter4:develop Sep 24, 2023
29 checks passed
@kenjis kenjis deleted the fix-shield-users-validation-rules branch September 24, 2023 21:06
@kenjis kenjis added the bug Something isn't working label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb