Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: [ar] adding Arabic translation support to shield #779

Closed
wants to merge 6 commits into from
Closed

lang: [ar] adding Arabic translation support to shield #779

wants to merge 6 commits into from

Conversation

mshannaq
Copy link
Contributor

adding support of Arabic Language

@datamweb datamweb changed the title adding Arabic translation support to shield lang: [ar] adding Arabic translation support to shield Aug 10, 2023
@datamweb datamweb added lang Languages file GPG-Signing needed Pull requests that need GPG-Signing labels Aug 10, 2023
@datamweb
Copy link
Collaborator

@mshannaq Thank you for PR.

Please sign the all commits:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits

More info #672 (comment)

Please add the test, see this comment:

#235 (comment)

@datamweb datamweb added the tests needed Pull requests that need tests label Aug 10, 2023
@kenjis
Copy link
Member

kenjis commented Aug 11, 2023 •
edited
Loading

The first two commits are not signed.
Also, please do not include merge commits like 8cb712b.
Read https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

@kenjis
Copy link
Member

kenjis commented Aug 11, 2023

What did you do? It seems this PR branch is broken.
8cb712b and 26ecac1 are exactly the same.

@mshannaq mshannaq closed this Aug 11, 2023
@mshannaq mshannaq deleted the arabic-translation branch August 11, 2023 00:32
@kenjis
Copy link
Member

kenjis commented Aug 11, 2023

If you don't know how to use git, I recommend you try https://learngitbranching.js.org/

@datamweb datamweb mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GPG-Signing needed Pull requests that need GPG-Signing lang Languages file tests needed Pull requests that need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshannaq @datamweb @kenjis