Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Session->checkAction method #1214

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

grimpirate
Copy link
Contributor

@grimpirate grimpirate commented Oct 28, 2024

Description
The checkAction method of the Session authenticator class includes unneeded assignment statements and comparisons. No functional change.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb
Copy link
Collaborator

datamweb commented Nov 1, 2024

@grimpirate Please run command:

composer cs-fix

@datamweb datamweb added the refactor Pull requests that refactor code label Nov 1, 2024
@grimpirate
Copy link
Contributor Author

grimpirate commented Nov 1, 2024

Please make the edit to include spaces after the not (!) operators. I don't have a local environment with GPG signing set up for this. I make these changes via the github online editor so I lack the capability to squash commits together and other such features. Thank you.

Copy link
Contributor Author

@grimpirate grimpirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants