Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unneeded Entities\Cast\IntBoolCast #1188

Merged
merged 1 commit into from
Aug 27, 2024
Merged

refactor: remove unneeded Entities\Cast\IntBoolCast #1188

merged 1 commit into from
Aug 27, 2024
+7 −106

Conversation

grimpirate
Copy link
Contributor

Description
Reopening of Pull Requests: #1186, #1187

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 27, 2024
kenjis
kenjis approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

datamweb
datamweb approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your conversations and I truly appreciate the effort you've put into the research and review. I'm glad to see that everything looks good in terms of backward compatibility. Thank you again for your thorough and professional work!

@datamweb datamweb merged commit 43add5a into codeigniter4:develop Aug 27, 2024
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grimpirate @kenjis @datamweb