Fix issue 966 dot array in old() function #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel P <[email protected]>
Signed-off-by: Gabriel P <[email protected]>
lonnieezell
requested changes
Mar 20, 2018
system/HTTP/IncomingRequest.php
Outdated
| helper('array'); | ||
|
|
||
| // Check for an array value in POST. | ||
| if (isset($_SESSION['_ci_old_input']['post']) && dot_array_search($key, $_SESSION['_ci_old_input']['post'])) |
There was a problem hiding this comment.
You're doing the dot array search twice here which is inefficient. More inefficient than assigning it to a variable, I believe. Please change that.
system/HTTP/IncomingRequest.php
Outdated
| } | ||
|
|
||
| // Check for an array value in GET. | ||
| if (isset($_SESSION['_ci_old_input']['get']) && dot_array_search($key, $_SESSION['_ci_old_input']['get'])) |
Signed-off-by: Gabriel P <[email protected]>
|
hum, the coverage check is ok in my fork ... https://github.com/gabpnr/CodeIgniter4/pull/1 |
|
@gabpnr The coverage calculations are a little weird sometimes. Your code is fine. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue 966 dot array in old() function
Signed-off-by: Gabriel P [email protected]