Set HTTP Version 1.1 on Post/Redirect/Get (PRG)

[natanfelles]

Fix #769
Fix #931

[natanfelles]

Inside a Controller the Validation Errors are not accessible in $validator. But is possible to get the last errors (_ci_validation_errors flashdata) with \Config\Services::validation()->getErrors().

What about after redirect()->back()->withInput() use the shared instance of the Validation with the $validator? Then enable to get the errors with $this->validator->getErrors().

---

This could be done in the Controller constructor:

$this->validator = Services::validation();

That will load the Validation every call, maybe check if has _ci_validation_errors flashdata (what could say if is coming back).

[lonnieezell]

A couple of things:

We shouldn't fix the HTTP version - 1.0 is theoretically possible to run into, and 2.0 is the new hotness. I'm pretty sure I was checking the incoming version at some point, but will have to check that later today when I'm not working the day job. We should be matching the incoming HTTP version or defaulting to 1.1.

The validator is a subject for a different thread, but the obvious problem being the values wouldn't survive the redirect. Additionally, I don't believe the validator is necessarily shared between models, and not 100% sure if that would be a good thing.

[natanfelles]

The version 1.1 is checked here. Maybe remove the HTTP/ and get the numbers to set below.

[natanfelles]

But the conditional forces to be 1.1...

[lonnieezell]

The thing to check first, I believe, is that the HTTP status is being sent correctly in the request, and that CI is copying that forward in to the response. This should happen in CodeIgniter.php.

If that's being set correctly there, it should already exist at the time of the redirect. But, yes, it looks like it needs to get checked properly during the redirect code.

[natanfelles]

Thank you! 😄