refactor: fix implicit array creation #9316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
implicit-array-creation
branch
from
d542f6d to
c06d928
Compare
datamweb
approved these changes
Dec 11, 2024
michalsn
approved these changes
Dec 11, 2024
samsonasik
approved these changes
Dec 11, 2024
|
Thank you @paulbalandan |
ddevsr
reviewed
Dec 12, 2024
Comment on lines
+125
to
127
| $filters = []; | ||
| $filters['before'] = array_intersect($filtersLongest['before'], $filtersShortest['before']); | ||
| $filters['after'] = array_intersect($filtersLongest['after'], $filtersShortest['after']); |
There was a problem hiding this comment.
Late to comment this, I prefer this kind of style.
$filters = [
'before' => array_intersect($filtersLongest['before'], $filtersShortest['before']),
'after' => array_intersect($filtersLongest['after'], $filtersShortest['after']),
];There was a problem hiding this comment.
Yeah, I realised later on that I can do it that way. You can send a PR to clean that up.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implicit arrays are prone to bugs.
Checklist: