Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explicitly declare $methods property as array in Filters configuration #9297

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

TechnoKaa
Copy link
Contributor

Resolved a fatal error:
Type of Config\Filters::$methods must be array (as in class CodeIgniter\Config\Filters)
by explicitly declaring $methods as an array to ensure compatibility with strict typing.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Updated Filters configuration to explicitly declare the $methods property as an array, ensuring compatibility with strict typing in PHP.
@michalsn michalsn merged commit 695829c into codeigniter4:develop Dec 2, 2024
9 checks passed
@michalsn
Copy link
Member

michalsn commented Dec 2, 2024

@TechnoKaa Thank you for your first contribution to the project!

@kenjis kenjis added the documentation Pull requests for documentation only label Dec 5, 2024
@kenjis kenjis changed the title refactor: explicitly declare $methods property as array in Filters configuration docs: explicitly declare $methods property as array in Filters configuration Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants