refactor: Apply code quality level 24 for Rector #9264
Merged
+3
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge 👍 |
michalsn
approved these changes
Nov 12, 2024
|
Thank you @michalsn for the review, let's merge ;) |
samsonasik
deleted the
refactor-apply-code-quality-level-24-for-rector
branch
kenjis
reviewed
Dec 5, 2024
| @@ -58,7 +58,7 @@ public function testGetFieldDataDefault(): void | |||
| $fields = $this->db->getFieldData($this->table); | |||
|
|
|||
| $idDefault = $this->getFieldMetaData('id', $this->table)->default; | |||
| $this->assertMatchesRegularExpression('/"ORACLE"."ISEQ\$\$_[0-9]+".nextval/', $idDefault); | |||
| $this->assertMatchesRegularExpression('/"ORACLE"."ISEQ\$\$_\d+".nextval/', $idDefault); | |||
There was a problem hiding this comment.
\d means a digit, but [0-9] means 0 to 9 (ASCII Arabic number). They are not the same.
Without u option, the result may be the exactly same, but the code implies different things.
So I don' t like this refactoring.
There was a problem hiding this comment.
It doesn't have /u so should be safe, also, this is test so not apply to end user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied
SimplifyRegexPatternRectorto simplify regex pattern to known rangesChecklist: