Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin python version for sphinx #9224

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

michalsn
Copy link
Member

Description
This PR pins the Python version to 3.12. Recently, we are not able to build the user guide correctly. This is because the imghdr module was removed in Python 3.13.

Running Sphinx v5.3.0

Extension error:
Could not import extension sphinx.builders.epub3 (exception: No module named 'imghdr')
make: *** [Makefile:20: html] Error 2

https://github.com/codeigniter4/CodeIgniter4/actions/runs/11307496056/job/31449280998?pr=9221

More information about removing the imghdr module:
sphinx-doc/sphinx#10440

Since for some reason we are blocked on Sphinx v5 (I'm guessing because of some extensions?), pinning the Python version is the only option.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn requested a review from kenjis October 13, 2024 07:54
@michalsn michalsn changed the title dev: pin python version for sphinx fix: pin python version for sphinx Oct 13, 2024
@michalsn michalsn requested a review from paulbalandan October 13, 2024 07:57
@michalsn
Copy link
Member Author

Should https://github.com/codeigniter4/CodeIgniter4/blob/develop/.github/workflows/deploy-distributables.yml#L162 be also updated to the pinned Python version? I guess yes.

@kenjis
Copy link
Member

kenjis commented Oct 19, 2024

Should https://github.com/codeigniter4/CodeIgniter4/blob/develop/.github/workflows/deploy-distributables.yml#L162 be also updated to the pinned Python version? I guess yes.

Probably, yes.

@michalsn
Copy link
Member Author

Updated.

@michalsn michalsn merged commit 28d7607 into codeigniter4:develop Oct 20, 2024
4 checks passed
@michalsn
Copy link
Member Author

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants