Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getValidated() when validation multiple asterisk #9220

Merged
merged 5 commits into from
Oct 22, 2024
Merged

fix: getValidated() when validation multiple asterisk #9220

merged 5 commits into from
Oct 22, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Oct 11, 2024

Description
Fixed #9219

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr mentioned this pull request Oct 11, 2024
Closed
@ddevsr ddevsr requested review from kenjis and michalsn October 11, 2024 03:25
@ddevsr ddevsr added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 11, 2024
michalsn
michalsn reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests that cover multiple asterisks, when validation rules failed?

user_guide_src/source/changelogs/v4.5.6.rst Outdated Show resolved Hide resolved
@ddevsr ddevsr changed the title fix: validation multiple asterisk fix: getValidated() when validation multiple asterisk Oct 11, 2024
@ddevsr ddevsr requested a review from michalsn October 11, 2024 07:53
michalsn
michalsn approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@michalsn
Copy link
Member

@ddevsr Can you rebase?

@ddevsr ddevsr force-pushed the fix-validation-end-wildcard branch from 9d754ae to cbbbb75 Compare October 21, 2024 06:21
michalsn
michalsn approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@michalsn michalsn merged commit 4a7fbd1 into codeigniter4:develop Oct 22, 2024
42 checks passed
@ddevsr ddevsr deleted the fix-validation-end-wildcard branch October 22, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

@kenjis kenjis Awaiting requested review from kenjis

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: getValidated() missing data when double wildcard rule
3 participants
@ddevsr @michalsn @paulbalandan