Debug Toolbar Enhancements

[natanfelles]

Now is possible get the Toolbar in HTML (debug bar), JSON and XML.

Accessing an existing file like http://localhost:8080/index.php?debugbar_time=1516260538 will return the content by the Accept Header, according with content negotiation, default is HTML.

The Toolbar data is an array saved with json_encode. When a request is done the negotiation occurs.

Yet is not working with the API Response. But this will facilitate the process.

[natanfelles]

At the moment the files are not being deleted, so that tests can be done by accessing the URLs directly.

Thinking about the possibility of maintaining a history of requests. Initially just keeping some files that can be handled later.

[natanfelles]

Having a history, besides being able to show it in the debug bar, also could be possible add a custom Header or append a link to the debug data.

I was thinking about being able to standardize API responses. For example:

{
	"meta":
	{
		"code": 200,
		"pagination":
		{
			"next": ""
		}
	},
	"data": {},
	"debug": {}
}

Since the the response body is inside the data. It would be nice to manipulate debugbar and already show some data by default. But this could overfill the output.

[natanfelles]

#863

[natanfelles]

http://jsonapi.org/

[natanfelles]

The code is a little messy. But this is a concept to meet the issue #83 .

I made a video, not listed here: https://www.youtube.com/watch?v=NqqyKVVc0qQ

Please tell us if this is the desired direction and what should be changed.

[lonnieezell]

I think it’s looking great! I haven’t had a chance to look over the code but did watch the video. Like it a lot.

One thing I would add is a setting in the config file for the max number of requests to save. 0 would be unlimited and any positive value would delete any files older than that number.

Great job! Thanks

[lonnieezell]

A few smaller things that need changing, but all in all looks pretty good. Would you say you're done with the feature aside from these changes?

[lonnieezell]

This would be nicer as a "switch". A bit simpler to read than a series of if/elseifs.

[lonnieezell]

This should be just the value of the icon itself. Leave the presentation to the front, since it could be used as an img src, or a background in CSS, etc.

[natanfelles]

All Collectors Icons are being saved with the debugbar file.

One approach could be to define them here to show the icons only in the HTML output. But all icons would have to be set in the template, which would ignore the icon() method defined there in classes.

Or are you referring to remove the img tag and leave only the base64? I didn't quite understand.

[lonnieezell]

Please bring the request object in through the constructor and saved as a class variable. Using the Services class within libraries is frowned upon typically.

[lonnieezell]

Please make the value here set in Config\App. Some people may have semi-sensitive information they don't want kept around long on their servers during testing, so they should be able to define the amount to keep around.

[natanfelles]

Yes. I think is done, aside the requested changes.

I'll see if I make the changes until tomorrow, but if you have time now and you want to improve this, feel free. 👍

[byazrail]

Collectors/Views::icon() img src bug.
History tab bug;
Argument 2 passed to CodeIgniter\View\Parser::prepareReplacement() must be of the type string, null given, called in system/View/Parser.php on line 580

[natanfelles]

@byazrail Please, clean your debug files in the WRITEPATH and say if it solves.