docs: [File Instance] RunTimeException if file does not exist #9037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File::getSize
andFile::getSizeByUnit()
may cause aRunTimeException
if the file does not exist or an error occurs. From the original docblock my expectation was that the functions would returnfalse
on an error (e.g. file does not exist), but the calledSplFileInfo::getSize()
throws a runtime error if the file does not exist.From the PHP docs
From the PHP docs it is not quite clear to me when to expect an exception and when to expect
false
.If return of
false
on any error is desired, I am happy to submit a PR to catch the exception.Checklist: