chore: update to new RectorConfig::configure() syntax for config #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge 👍 |
kenjis
approved these changes
Jun 25, 2024
|
Thank you @kenjis for the review, let's merge ;) |
samsonasik
commented
Jun 26, 2024
| ->withParallel(120, 8, 10) | ||
| ->withCache( | ||
| // Github action cache or local | ||
| is_dir('/tmp') ? '/tmp/rector' : sys_get_temp_dir() . '/rector', |
There was a problem hiding this comment.
I just make quick fix on develop for fallback null on local 86480f4 to use default value from rector if /tmp not exists.
Ref:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
new
RectorConfig::configure()syntax exists since Rector 1.0, this PR update to new syntax.Checklist: