Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5.3 Ready code #8997

Merged
merged 79 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
98465f6
docs: restore goals.rst from 3.0 user guide
kenjis Feb 18, 2024
ce97114
docs: Change getOption's parameter name in cli/cli_request.rst
obozdag Jun 9, 2024
27c4e8c
docs: Fix typo in extending/core_classes.rst
obozdag Jun 9, 2024
8c871fc
docs: add changelog and upgrade for v4.5.3
kenjis Jun 10, 2024
727c0df
Merge pull request #8950 from kenjis/docs-changelog-4.5.3
kenjis Jun 10, 2024
55a4a78
Merge pull request #8943 from obozdag/patch-18
paulbalandan Jun 10, 2024
ce3750c
Merge pull request #8942 from obozdag/patch-17
paulbalandan Jun 10, 2024
7f15535
Combine similar deleteMatching test cases
paulbalandan Jun 10, 2024
3b7046a
Add failing test for cache prefix
paulbalandan Jun 10, 2024
e86b75a
Fix rector transform
paulbalandan Jun 10, 2024
9099e20
Validate pattern against prefix
paulbalandan Jun 10, 2024
3d5b97d
refactor RedisHandler::deleteMatching()
paulbalandan Jun 10, 2024
042525c
test: add test cases for routes with integer
kenjis Jun 12, 2024
4e35d38
fix: TypeError in DefinedRouteCollector::collect()
kenjis Jun 12, 2024
d2e50af
test: add tests for "migrate:rollback -b"
kenjis Jun 12, 2024
3cfb940
fix: "migration:rollback -b" does not work due to TypeError
kenjis Jun 12, 2024
cf0e87d
Merge pull request #8557 from kenjis/docs-concepts-goals.rst
kenjis Jun 12, 2024
766df8c
Add comments to each data
paulbalandan Jun 12, 2024
cb23bdb
Remove space
paulbalandan Jun 12, 2024
c647c47
docs: Small typos in extending/events.rst
obozdag Jun 12, 2024
33477f8
test: add test for if_exist and array data
kenjis Jun 12, 2024
1ca24da
fix: if_exist does not work with array data
kenjis Jun 12, 2024
cdec7d0
fix: revert rule `alpha`
kenjis Jun 12, 2024
a13f54d
Merge pull request #8961 from obozdag/patch-17
kenjis Jun 12, 2024
04c4d4b
chore: add autoload.exclude-from-classmap to suppress warnings
kenjis Jun 12, 2024
2cb6220
chore: add Config namespace to appstarter composer.json
kenjis Jun 13, 2024
eee496c
docs: add note
kenjis Jun 13, 2024
b6c668c
Merge pull request #8952 from paulbalandan/redis-delete-matching-prefix
kenjis Jun 14, 2024
6c7144b
Merge pull request #8962 from kenjis/update-composer-exclude-from-cla…
kenjis Jun 15, 2024
a12d45c
style: fix cs
paulbalandan Jun 16, 2024
bab2391
chore: add checks for RELEASE and VERSION variables
paulbalandan Jun 16, 2024
5bac584
Merge pull request #8967 from paulbalandan/cs
kenjis Jun 17, 2024
8360ffb
chore: workaround for phpDocumentor error
kenjis Jun 17, 2024
3e2aefb
Merge pull request #8969 from kenjis/fix-deploy-apidocs.yml
kenjis Jun 17, 2024
7aced76
Merge pull request #8957 from kenjis/fix-RouteCollection-TypeError
kenjis Jun 17, 2024
24a7673
Merge pull request #8958 from kenjis/fix-migrate-rollback-batch
kenjis Jun 17, 2024
8a61688
refactor: remove unneeded initialization
kenjis Jun 18, 2024
4c01499
refactor: simplify if condition
kenjis Jun 18, 2024
a0e35ba
fix: change to give priority to first command discoverd
kenjis May 16, 2024
e6b5931
test: add test
kenjis Jun 18, 2024
099ce7d
test: fix PHPStan errors
kenjis Jun 18, 2024
71dc065
Merge pull request #8968 from paulbalandan/script-check
kenjis Jun 19, 2024
ad73071
Merge pull request #8971 from kenjis/test-fix-CommandTest-phpstan-errors
kenjis Jun 19, 2024
2fae945
Merge pull request #8959 from kenjis/fix-if_exist-with-array
kenjis Jun 19, 2024
19d5755
Merge pull request #8963 from kenjis/appstarter-autoload-Config-ns
kenjis Jun 19, 2024
6107a60
test: add `spark routes` test for route with regexp
kenjis Jun 19, 2024
adbc291
fix: `spark routes` may show BadRequestException when regexp is in route
kenjis Jun 19, 2024
4ad4bd3
docs: add PHPDoc tags
kenjis Jun 19, 2024
b51df1c
docs: fix PHPStan in Commands
ddevsr Jun 14, 2024
ea30aaf
Update system/Commands/Database/ShowTableInfo.php
ddevsr Jun 17, 2024
c2e843f
Update system/Commands/Database/ShowTableInfo.php
ddevsr Jun 17, 2024
b0c6c66
fix: remove @used-by PHPDocs
ddevsr Jun 19, 2024
c8b8995
Merge pull request #8964 from ddevsr/phpstan-commands
kenjis Jun 19, 2024
cd46db1
Merge pull request #8974 from kenjis/fix-spark-routes-BadRequestExcep…
kenjis Jun 19, 2024
d6d1434
Merge pull request #8970 from kenjis/refactor-orderBy
kenjis Jun 19, 2024
b9afd48
docs: fix incorrect description for route group filter
kenjis Jun 20, 2024
53bfdef
Merge pull request #8978 from kenjis/fix-docs-nesting-group-filter
kenjis Jun 21, 2024
dbaeea2
chore(deps-dev): update rector/rector requirement from 1.1.0 to 1.1.1
dependabot[bot] Jun 21, 2024
abfcba7
fix: return and param types of BaseConnection
paulbalandan Jun 21, 2024
54b0441
fix: if conditions to build DSN
kenjis Jun 22, 2024
9a9da14
refactor: replace empty()
kenjis Jun 22, 2024
fa5f5c6
fix: Deprecated
kenjis Jun 22, 2024
5ee0df2
refactor: replace empty()
kenjis Jun 22, 2024
99346b4
refactor: move if conditions to isValidDSN()
kenjis Jun 22, 2024
4e68814
Merge pull request #8983 from paulbalandan/connection-types
paulbalandan Jun 22, 2024
3ab0644
refactor: using phpunit 10 assertObjectHasNotProperty() and assertObj…
samsonasik Jun 22, 2024
61d2742
Merge pull request #8991 from samsonasik/refactor-phpunit-assert-object
samsonasik Jun 23, 2024
9d02066
Merge pull request #8898 from kenjis/fix-command-discovery
kenjis Jun 24, 2024
ab64aeb
Merge pull request #8986 from kenjis/fix-OCI8-connect
kenjis Jun 24, 2024
d54f613
test: add test for translateUriToCamelCase and Default Method Fallback
kenjis Jun 21, 2024
4882913
fix: Auto Routing (Improved) Default Method Fallback does not work wi…
kenjis Jun 21, 2024
96de786
refactor: rename method name
kenjis Jun 21, 2024
d474187
docs: improve comment
kenjis Jun 24, 2024
9f6bf3f
fix: move rewrite.php to system/rewrite.php
kenjis Jun 24, 2024
eaa4339
Merge pull request #8980 from kenjis/fix-AutoRouterImproved-translate…
kenjis Jun 24, 2024
e0e8f83
Merge pull request #8982 from codeigniter4/dependabot/composer/rector…
kenjis Jun 25, 2024
dd39902
Merge pull request #8995 from kenjis/fix-command-loads-rewrite.php
kenjis Jun 25, 2024
f14bc90
Prep for 4.5.3 release
kenjis Jun 25, 2024
3c2b914
Merge pull request #8996 from kenjis/release-4.5.3
kenjis Jun 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/scripts/deploy-userguide
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,26 @@
SOURCE=$1
TARGET=$2
RELEASE=$3
VERSION=`echo "$RELEASE" | cut -c 2-`

# Check if RELEASE is empty
if [ -z "$RELEASE" ]; then
echo "Error: \$RELEASE parameter is empty."
exit 1
fi

VERSION=$(echo "$RELEASE" | cut -c 2-)

# Check if VERSION is empty
if [ -z "$VERSION" ]; then
echo "Error: Failed to extract \$VERSION from \$RELEASE parameter '$RELEASE'."
exit 1
fi

# Check if VERSION matches the format X.Y.Z
if ! [[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "Error: VERSION '$VERSION' does not match the expected format X.Y.Z."
exit 1
fi

echo "Preparing for version $3"
echo "Merging files from $1 to $2"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-apidocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Build API in source repo
working-directory: source
run: |
php tools/phpDocumentor run --ansi --verbose
php tools/phpDocumentor --ansi --verbose
cp -R ${GITHUB_WORKSPACE}/source/api/build/* ${GITHUB_WORKSPACE}/api/docs

- name: Deploy to API repo
Expand Down
23 changes: 23 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
# Changelog

## [v4.5.3](https://github.com/codeigniter4/CodeIgniter4/tree/v4.5.3) (2024-06-25)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.5.2...v4.5.3)

### Fixed Bugs

* fix: `RedisHandler::deleteMatching()` not deleting matching keys if cache prefix is used by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/8952
* fix: TypeError in DefinedRouteCollector::collect() by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8957
* fix: `migrate:rollback -b` does not work due to TypeError by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8958
* fix: [Validation] `if_exist` does not work with array data by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8959
* chore: add `Config` namespace to appstarter autoload.psr4 by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8963
* fix: `spark routes` may show BadRequestException when a route has a regexp by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8974
* docs: fix incorrect description for route group filter by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8978
* fix: return and param types of BaseConnection by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/8983
* fix: precedence of command classes with the same `$name` by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8898
* fix: [OCI8] if conditions to build DSN by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8986
* fix: [Auto Routing Improved] Default Method Fallback does not work with `$translateUriToCamelCase` by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8980
* fix: `command()` may execute `rewrite.php` by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8995

### Refactoring

* refactor: BaseBuilder::orderBy() by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8970
* refactor: using phpunit 10 assertObjectHasNotProperty() and assertObjectHasProperty() by @samsonasik in https://github.com/codeigniter4/CodeIgniter4/pull/8991

## [v4.5.2](https://github.com/codeigniter4/CodeIgniter4/tree/v4.5.2) (2024-06-10)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.5.1...v4.5.2)

Expand Down
3 changes: 2 additions & 1 deletion admin/starter/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
},
"autoload": {
"psr-4": {
"App\\": "app/"
"App\\": "app/",
"Config\\": "app/Config"
},
"exclude-from-classmap": [
"**/Database/Migrations/**"
Expand Down
6 changes: 4 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"phpunit/phpcov": "^9.0.2",
"phpunit/phpunit": "^10.5.16",
"predis/predis": "^1.1 || ^2.0",
"rector/rector": "1.1.0",
"rector/rector": "1.1.1",
"vimeo/psalm": "^5.0"
},
"replace": {
Expand Down Expand Up @@ -64,7 +64,9 @@
"CodeIgniter\\": "system/"
},
"exclude-from-classmap": [
"**/Database/Migrations/**"
"**/Database/Migrations/**",
"system/ThirdParty/**",
"tests/system/Config/fixtures/**"
]
},
"autoload-dev": {
Expand Down
2 changes: 1 addition & 1 deletion phpdoc.dist.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<output>api/build/</output>
<cache>api/cache/</cache>
</paths>
<version number="4.5.2">
<version number="4.5.3">
<api format="php">
<source dsn=".">
<path>system</path>
Expand Down
Loading
Loading