-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix helpers/form_helper.rst #8935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change HTML 'tag's to 'element's in helpers/form_helper.rst
kenjis
approved these changes
Jun 5, 2024
…Kenjis) helpers/form_helper.rst Fix some typos and expand csrf auto-generation explanation (by Kenjis) helpers/form_helper.rst
…y.rst Add label to Enable CSRF Protection header in libraries/security.rst
kenjis
reviewed
Jun 5, 2024
kenjis
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the link.
kenjis
reviewed
Jun 5, 2024
kenjis
changed the title
docs: Change HTML 'tag's to 'element's in helpers/form_helper.rst
docs: fix helpers/form_helper.rst
Jun 5, 2024
Co-authored-by: kenjis <[email protected]>
@kenjis Sorry. Same mistake while copy paste. |
My Suggested change was not to fix HTML link. Just fix the sample code format. |
Added label to $globals in incoming/filters.rst
Fix filters-globals link in helpers/form_helper.rst
kenjis
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Superseds #8915
Checklist: