Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in errors.rst #8907

Closed
wants to merge 1 commit into from
Closed

Conversation

iamsyh
Copy link
Contributor

@iamsyh iamsyh commented May 22, 2024

Description
added "are" instead of "is" as the word "Exceptions" is plural

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

added "are" instead of "is" as it's plural
@iamsyh iamsyh changed the title Update errors.rst Fix errors.rst May 22, 2024
@kenjis kenjis added the documentation Pull requests for documentation only label May 23, 2024
@kenjis
Copy link
Member

kenjis commented May 23, 2024

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

@kenjis kenjis changed the title Fix errors.rst docs: fix typo in errors.rst May 23, 2024
@kenjis
Copy link
Member

kenjis commented May 23, 2024

Please fix the test failure.

Comment on lines +22 to 23
What are Exceptions
------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
What are Exceptions
------------------
What are Exceptions
-------------------

Apply to pass the test.

@kenjis kenjis added waiting for info Issues or pull requests that need further clarification from the author abandoned? Activity on a pull request is almost none since the last interaction with the author and removed waiting for info Issues or pull requests that need further clarification from the author labels Jun 1, 2024
@kenjis kenjis mentioned this pull request Jun 6, 2024
2 tasks
@kenjis
Copy link
Member

kenjis commented Jun 6, 2024

Closed by #8938

@kenjis kenjis closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned? Activity on a pull request is almost none since the last interaction with the author documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants