Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Prevent text-wrap in user guide #8906

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

obozdag
Copy link
Contributor

@obozdag obozdag commented May 21, 2024

Description
Prevent text-wrap in user guide. For example

$this-
>validateData() should stay unwrapped ($this->validateData()).

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Prevent text-wrap in user guide. For example $this-
>validateData() should stay unwrapped ($this->validateData()).
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide screenshots before and after PR.

@obozdag
Copy link
Contributor Author

obozdag commented May 22, 2024

@datamweb As seen below
Screenshot 2024-05-21 at 08 40 00
Screenshot 2024-05-21 at 08 40 44

Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

@kenjis kenjis added the documentation Pull requests for documentation only label May 23, 2024
@kenjis
Copy link
Member

kenjis commented May 23, 2024

Looks good.
The HTML for above.

The <code class="docutils literal notranslate"><span class="pre">validateData()</span></code> method is a method in the Controller. It uses
the <strong>Validation class</strong> inside. See <a class="reference internal" href="../incoming/controllers.html#controller-validatedata"><span class="std std-ref">$this-&gt;validateData()</span></a>.

@kenjis kenjis merged commit 4100729 into codeigniter4:develop May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants