Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CLI::promptByMultipleKeys() and prompt() #8873

Merged
merged 6 commits into from
May 13, 2024
Merged

fix: CLI::promptByMultipleKeys() and prompt() #8873

merged 6 commits into from
May 13, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 8, 2024 •
edited
Loading

Description
Fixes #8861

  • fix CLI::promptByMultipleKeys() TypeError
  • fix bug that CLI::prompt() may incorrectly return default value

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label May 8, 2024
@kenjis kenjis mentioned this pull request May 8, 2024
Closed
@kenjis kenjis force-pushed the fix-CLI-user-input branch from ffbb4b7 to e772b9d Compare May 8, 2024 09:09
@kenjis kenjis merged commit c7c4eb4 into codeigniter4:develop May 13, 2024
40 checks passed
@kenjis kenjis deleted the fix-CLI-user-input branch May 13, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: CLI class, method promptByMultipleKeys() - default $input is of wrong type
2 participants
@kenjis @michalsn