Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: small fixes in upgrade responses.rst #8815

Merged
merged 3 commits into from
Apr 30, 2024
Merged

docs: small fixes in upgrade responses.rst #8815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98f44fc
docs: fix page title
kenjis Apr 21, 2024
8b37b83
docs: add explanation
kenjis Apr 21, 2024
d6f1e88
docs: fix typo
kenjis Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion user_guide_src/source/installation/upgrade_4xx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,8 @@ Upgrading Libraries
upgrade_images
upgrade_localization
upgrade_migrations
upgrade_pagination
upgrade_responses
upgrade_pagination
Comment on lines -257 to +258
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I assume this was alphabetical.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I changed the page title.
Screenshot 2024-04-23 6 26 33

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output class makes more sense from the perspective of a CI3 user.

upgrade_routing
upgrade_security
upgrade_sessions
Expand Down
9 changes: 5 additions & 4 deletions user_guide_src/source/installation/upgrade_responses.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Upgrade HTTP Responses
######################
Upgrade Output Class
####################

.. contents::
:local:
Expand All @@ -12,11 +12,12 @@ Documentations

What has been changed
=====================
- The methods have been renamed
- The Output class has been changed to the Response class.
- The methods have been renamed.

Upgrade Guide
=============
1. The methods in the HTTP Responses class are named slightly different. The most important change in the naming is the switch from underscored method names to camelCase. The method ``set_content_type()`` from version 3 is now named ``setContentType()`` and so on.
1. The methods in the HTTP Response class are named slightly different. The most important change in the naming is the switch from underscored method names to camelCase. The method ``set_content_type()`` from version 3 is now named ``setContentType()`` and so on.
2. In the most cases you have to change ``$this->output`` to ``$this->response`` followed by the method. You can find all methods in :doc:`../outgoing/response`.

Code Example
Expand Down