-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [QueryBuilder] TypeError in join() with BETWEEN #8792
Conversation
Can someone review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather see the use of RawSql
for complicated conditions, but since the issue with BETWEEN
is described as a regression, I think this is fine.
The version has been upgraded to 4.5.2. $model = new HogeModel(); "Argument '1' passed to insert() is expected to be of type object|row_array|null, array given" Please fix it. |
Why your VS Code reads Lines 779 to 788 in 53bfdef
If it reads CodeIgniter4/system/BaseModel.php Line 50 in 53bfdef
|
Thank you. Windows 11 Pro 23H2 WSL2 It was very helpful. |
??? Model.php on line 268 & BaseModel.php on line 656 is displays "undefined property" error form intelephense. Here and now (´;д;`) |
Bad $model = new HogeModel();
$data = [
'hoge' => 'fuga'
];
$model->insert($data); Good private function hoge()
{
$data = [
'hoge' => 'fuga'
];
$this->insertHoge($data);
}
private function insertHoge($data)
{
$model = new HogeModel();
$model->insert($data);
} |
Description
Fixes #8791
This PR makes the same behavior as v4.4.x or before.
Checklist: