Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor CURLRequset tests #8763

Merged
merged 4 commits into from
Apr 12, 2024
Merged

test: refactor CURLRequset tests #8763

merged 4 commits into from
Apr 12, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 11, 2024 •
edited
Loading

Needs #8760

Description

  • refactor CURLRequset tests

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft April 11, 2024 09:16
@kenjis kenjis added the testing Pull requests that changes tests only label Apr 11, 2024
@kenjis kenjis force-pushed the refactor-CURLRequest-tests branch from 17696c4 to c40410f Compare April 11, 2024 22:51
@kenjis kenjis marked this pull request as ready for review April 11, 2024 22:52
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@github-actions github-actions bot added the stale Pull requests with conflicts label Apr 12, 2024
@kenjis kenjis force-pushed the refactor-CURLRequest-tests branch from c40410f to c6c4f81 Compare April 12, 2024 00:57
@kenjis kenjis removed the stale Pull requests with conflicts label Apr 12, 2024
@kenjis kenjis merged commit 774cbd5 into codeigniter4:develop Apr 12, 2024
40 checks passed
@kenjis kenjis deleted the refactor-CURLRequest-tests branch April 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb