Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Images] add AVIF support #8713

Closed
wants to merge 10 commits into from
Closed

feat: [Images] add AVIF support #8713

wants to merge 10 commits into from
+25 −5

Conversation

ALTITUDE-DEV-FR
Copy link
Contributor

@ALTITUDE-DEV-FR ALTITUDE-DEV-FR commented Apr 5, 2024 •
edited by kenjis
Loading

Description
Supersedes #8560

AVIF vars added and languages associed.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ALTITUDE-DEV-FR ALTITUDE-DEV-FR changed the title feat: Add AVIF supported feat: add AVIF support Apr 5, 2024
datamweb
datamweb reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs with any enhancement should be sent to next minor version branch, e.g. "4.5".

@ALTITUDE-DEV-FR ALTITUDE-DEV-FR changed the base branch from develop to 4.5 April 5, 2024 14:37
@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Apr 5, 2024
@kenjis
Copy link
Member

kenjis commented Apr 5, 2024

Please remove unrelated commits, and fix the coding style.
Also test code is needed.

@kenjis kenjis added the tests needed Pull requests that need tests label Apr 5, 2024
@kenjis kenjis changed the title feat: add AVIF support feat: [Images] add AVIF support Apr 5, 2024
@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Apr 6, 2024
@kenjis kenjis deleted the branch codeigniter4:4.5 April 7, 2024 04:47
@kenjis kenjis closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb left review comments

Assignees
No one assigned
Labels
4.5 docs needed Pull requests needing documentation write-ups and/or revisions. enhancement PRs that improve existing functionalities tests needed Pull requests that need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ALTITUDE-DEV-FR @kenjis @datamweb @Pebryan354